From e3560af2e9a878463d1a57cc817973c4c9e1b7ac Mon Sep 17 00:00:00 2001 From: lone-cloud Date: Fri, 10 Feb 2017 19:07:00 -0800 Subject: [PATCH] bug fixes, minor stuff --- README.md | 18 +++++------------- .../pods/components/light-group/component.js | 2 +- .../app/pods/components/music-tab/component.js | 1 + mobile/ember-cordova/cordova/config.xml | 3 ++- .../pods/components/light-group/component.js | 2 +- web/app/pods/components/music-tab/component.js | 1 + 6 files changed, 11 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 84c41a1..a2ee78b 100644 --- a/README.md +++ b/README.md @@ -2,10 +2,10 @@ Music awesomeness for hue lights. -It lives at http://www.huegasm.com +It lives at http://www.huegasm.com and on https://play.google.com/store/apps/details?id=com.hoboman313.huegasm ## Current priorities -- create a hybrid app with Cardova +- create a Huegasm Chrome extension ## SIGNING /ember-cordova/platforms/android/release-signing.properties: @@ -15,8 +15,6 @@ keyAlias=huegasm keyPassword=... storePassword=... -keytool -genkey -v -keystore huegasm.keystore -alias huegasm -keyalg RSA -keysize 2048 -validity 10000 - ## LE MONKEY PATCHES - webView.setVerticalScrollBarEnabled(true); - @Override @@ -29,14 +27,8 @@ keytool -genkey -v -keystore huegasm.keystore -alias huegasm -keyalg RSA -keysiz pluginManager.onStop(); } -- channel.onStop = cordova.addDocumentEventHandler('stop'); -- case 'stop': +- channel.onStop = cordova.addDocumentEventHandler('stop'); from channel.onDeviceReady = cordova.addStickyDocumentEventHandler('deviceready'); +- case 'stop': after case 'pause': +- add to Android manifest Just search for 'pause' and add the same type of event stuff for 'stop'. This is needed for properly split screening Huegasm with other apps. - -## POSSIBLE FUTURE FEATURES -- decode the hue color better -- better visualizations -- beat settings by interval -- auto beat detection mode -- display player time when hovering over seek bar diff --git a/mobile/app/pods/components/light-group/component.js b/mobile/app/pods/components/light-group/component.js index 294bf49..508f8d3 100644 --- a/mobile/app/pods/components/light-group/component.js +++ b/mobile/app/pods/components/light-group/component.js @@ -95,7 +95,7 @@ export default Component.extend({ if(!isNone(activeLightsCache)){ activeLightsCache.forEach(function(i){ - if (lightsData.hasOwnProperty(i) && lightsData[i].state.reachable) { + if (!isNone(lightsData) && lightsData.hasOwnProperty(i) && lightsData[i].state.reachable) { activeLights.pushObject(i); } }); diff --git a/mobile/app/pods/components/music-tab/component.js b/mobile/app/pods/components/music-tab/component.js index 99264b1..91b8953 100644 --- a/mobile/app/pods/components/music-tab/component.js +++ b/mobile/app/pods/components/music-tab/component.js @@ -267,6 +267,7 @@ export default Component.extend(helperMixin, visualizerMixin, { this.send('handleNewSoundCloudURL', 'https://soundcloud.com/mrsuicidesheep/elo-method-subranger-solace'); this.send('handleNewSoundCloudURL', 'https://soundcloud.com/mrsuicidesheep/90-pounds-of-pete-waited-too-long-feat-devon-baldwin'); this.send('handleNewSoundCloudURL', 'https://soundcloud.com/mrsuicidesheep/draper-eyes-open'); + this.send('handleNewSoundCloudURL', 'https://soundcloud.com/itspapaya/sunny'); this.get('storage').set('huegasm.firstVisit', false); diff --git a/mobile/ember-cordova/cordova/config.xml b/mobile/ember-cordova/cordova/config.xml index 0769e44..343739b 100644 --- a/mobile/ember-cordova/cordova/config.xml +++ b/mobile/ember-cordova/cordova/config.xml @@ -1,5 +1,5 @@ - + Huegasm @@ -15,6 +15,7 @@ + diff --git a/web/app/pods/components/light-group/component.js b/web/app/pods/components/light-group/component.js index 68c666f..3f86d23 100644 --- a/web/app/pods/components/light-group/component.js +++ b/web/app/pods/components/light-group/component.js @@ -98,7 +98,7 @@ export default Component.extend({ if(!isNone(activeLightsCache)){ activeLightsCache.forEach(function(i){ - if (lightsData.hasOwnProperty(i) && lightsData[i].state.reachable) { + if (!isNone(lightsData) && lightsData.hasOwnProperty(i) && lightsData[i].state.reachable) { activeLights.pushObject(i); } }); diff --git a/web/app/pods/components/music-tab/component.js b/web/app/pods/components/music-tab/component.js index 139e00e..2ecc914 100644 --- a/web/app/pods/components/music-tab/component.js +++ b/web/app/pods/components/music-tab/component.js @@ -289,6 +289,7 @@ export default Component.extend(helperMixin, visualizerMixin, { this.send('handleNewSoundCloudURL', 'https://soundcloud.com/mrsuicidesheep/elo-method-subranger-solace'); this.send('handleNewSoundCloudURL', 'https://soundcloud.com/mrsuicidesheep/90-pounds-of-pete-waited-too-long-feat-devon-baldwin'); this.send('handleNewSoundCloudURL', 'https://soundcloud.com/mrsuicidesheep/draper-eyes-open'); + this.send('handleNewSoundCloudURL', 'https://soundcloud.com/itspapaya/sunny'); this.get('storage').set('huegasm.firstVisit', false);